PROBLEM :New Tutorial : PWM on ATmega168

[zverukas]

Hi, i can't compile it on gcc.
I always receive an error: "../pwm.c:250:23: error: "*" may not appear in macro parameter list"
on lines :
#define pwmSet9(ICR1 * val /255)   OCR1A=val     
#define pwmSet10(ICR1 * val /255)   OCR1B=val

also warnings : "../pwm.c:135: warning: implicit declaration of function 'sbi'"
on :
void pwmOn9(void) {
   /****************************/
   /* Pin 9 on*/
   /****************************/
//9 A on - set at Bottom, clear at compare match
   sbi(TCCR1A,7);
  cbi(TCCR1A,6);

any ideas ?

[Webbot]

Hi, i can't compile it on gcc.
I always receive an error: "../pwm.c:250:23: error: "*" may not appear in macro parameter list"
on lines :
#define pwmSet9(ICR1 * val /255)   OCR1A=val     
#define pwmSet10(ICR1 * val /255)   OCR1B=val

Yep - not surprised - that #define is full of errors. The original author of that tutorial was airman00. Hopefully you will get a response from him and he will fix the tutorial.

also warnings : "../pwm.c:135: warning: implicit declaration of function 'sbi'"
on :
void pwmOn9(void) {
   /****************************/
   /* Pin 9 on*/
   /****************************/
//9 A on - set at Bottom, clear at compare match
   sbi(TCCR1A,7);
  cbi(TCCR1A,6);

any ideas ?

The cbi and sbi marcros aren't defined
Try placing this at the top of your program-

Code: [Select]

#ifndef cbi
    #define cbi(reg,bit)    reg &= ~(BV(bit))
#endif
#ifndef sbi
    #define sbi(reg,bit)    reg |= (BV(bit))
#endif


[zverukas]

hmm

../pwm.c:142: warning: implicit declaration of function 'BV'

[KurtEck]

My quick guess at this is BV is probably defined something like:

#define BV(bit) (1<<bit)

You can probably put this in an #ifndef like the other ones...

Kurt